-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show notification number for issues, prs, discussions #1276
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd leave this one marinating a bit... I'm not sure if this is useful information and it is polluting an already quite polluted UI.
Maybe reducing opacity to like 60? And making it a font step smaller? |
It's another step on our journey to GitHub UI/UX consistency. It wasn't until this week that I realized nowhere in our current UX do we mention the issue numbers 🙃 |
I agree with the part about consistency, but we must have less UI elements, because we don't have the luxury of a full page imo |
My preferred approach is no issue number at the end of the day. I've locally played around with
Edit: Now also in https://github.com/gitify-app/gitify/blob/main/CONTRIBUTING.md#project-philosophy |
@bmulholland @setchy @Araxeus @adufr opinions on the above? |
I personally don't see value in showing issue number in Gitify, but I guess it could be optional? |
I still think this is pretty innocent change 😅 using this mockup;
If it's such a big concern, another option could be only having it in the mouse-over label text 🤷♂️ |
Point still remains, what is the value of it? But if this is useful to anyone, that is indeed a good compromise! |
Would you really check out a branch based on a number from a notification title? I think you would usually enter the notification, see what's actually inside it, then decide if you should check out or not |
I'll give my opinion on this since I've been tagged, even though I haven't contributed recently I like the fact that Gitify can be modular. I personally don't have a use case for this, but IMO it's worth adding it behind a setting (probably disabled by default though?)
@afonsojramos: you are very right, that's why I'd disable it by default, but having multiple features like this that could be enabled/disabled would solve this problem; the user can just add whatever elements he wants and which fits its use-case @setchy: about the design, I think I prefer this one too 😁 |
The issue with "the user can just add whatever elements he wants and which fits its use-case", is that then we'll need to have this in mind with future developments, as they are things that we might not be seeing in local development, but might break or affect without us realising. Too many options can be very hard to work with. But, this is minimal I suppose, so I think we can move forward with this 🚀 (However, we'll need another setting for this I reckon) |
the issue/pr/discussion number is already flagged with the |
@setchy So do colors, last commenter and state, which I think are very useful and with no extra UI elements, while this one does add a new element, hence the ask for a new setting. |
Added a new setting. |
Updated
![Screenshot 2024-06-21 at 7 17 43 AM](https://private-user-images.githubusercontent.com/386277/341745481-da07571b-27a1-4c54-bfb8-93884ce45c0f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYwNDc4NzIsIm5iZiI6MTcyNjA0NzU3MiwicGF0aCI6Ii8zODYyNzcvMzQxNzQ1NDgxLWRhMDc1NzFiLTI3YTEtNGM1NC1iZmI4LTkzODg0Y2U0NWMwZi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTExJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkxMVQwOTM5MzJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00YmRjYjQ4NzgzMzNhNzIxZWM4ODZkYWY5ODdhNjVkNGZkZGNhNWU0Y2ZiNWMyNmVjZWQ5NmNiZjYzYjdhMjk3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.7NbGVd5iGkcKPFRvrrL6TWkKO5BKEuYw22FmfnvnsFw)
Original
![Screenshot 2024-06-19 at 9 49 02 AM](https://private-user-images.githubusercontent.com/386277/341099992-8f12fb94-fff3-4dc2-b2c9-c417aff63fe1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYwNDc4NzIsIm5iZiI6MTcyNjA0NzU3MiwicGF0aCI6Ii8zODYyNzcvMzQxMDk5OTkyLThmMTJmYjk0LWZmZjMtNGRjMi1iMmM5LWM0MTdhZmY2M2ZlMS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTExJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkxMVQwOTM5MzJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xNTMxZWIyMDc4Y2YxMGNhNTMxM2FmZjlmMjU4NTdhYThmYWJiYzRmNjI2NWVlNDAwNzcxYTdlYWVjNTMwMDU1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.cUTcvvshx0CouwI_874MgYMzXhLaYtwdoq-2nk9gnuM)