Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add ts-check to js files #1285

Merged
merged 1 commit into from
Jun 20, 2024
Merged

chore: add ts-check to js files #1285

merged 1 commit into from
Jun 20, 2024

Conversation

afonsojramos
Copy link
Member

No description provided.

@setchy
Copy link
Member

setchy commented Jun 20, 2024

Would love to make these js files TS in time, too

@setchy setchy added the build Build, action or package manager changes label Jun 20, 2024
@setchy setchy added this to the Release 5.10.0 milestone Jun 20, 2024
@afonsojramos
Copy link
Member Author

Would love to make these js files TS in time, too

With webpack I think that would bring us more headaches than we need I think, but feel free to explore 🙈

@afonsojramos afonsojramos merged commit 266207a into main Jun 20, 2024
8 checks passed
@afonsojramos afonsojramos deleted the chore/ts-check-js branch June 20, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@setchy setchy setchy approved these changes

@bmulholland bmulholland Awaiting requested review from bmulholland bmulholland is a code owner

Assignees
No one assigned
Labels
build Build, action or package manager changes
Projects
None yet
Milestone
Release 5.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@afonsojramos @setchy