Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reset to default settings #1321

Merged
merged 6 commits into from
Jul 5, 2024
Merged

Conversation

setchy
Copy link
Member

@setchy setchy commented Jun 28, 2024

Add a reset default settings option. Of increasing usefulness as we've been adding, and may continue to add more settings in future.

Screenshot 2024-06-28 at 8 14 28 AM

@setchy setchy added the enhancement New feature or enhancement to existing functionality label Jun 28, 2024
@setchy setchy added this to the Release 5.10.0 milestone Jun 28, 2024
@bmulholland
Copy link
Collaborator

I perceive that icon as "undo my last change," not "undo all changes, ever." I could, therefore, click it and get effective data loss without intending...

@setchy
Copy link
Member Author

setchy commented Jul 1, 2024

Is there an alternative icon you'd propose - https://primer.style/foundations/icons?

Would there be a different location you'd prefer?

I figured the hover text was enough 🤷‍♂️

@afonsojramos
Copy link
Member

I'd argue more against the feature, than the icon itself. Why would we want this?

(But if we really want this, I'd say actual text aligned to the right saying "Reset to defaults *currentUndoIconHere*")

@setchy
Copy link
Member Author

setchy commented Jul 4, 2024

I'd argue more against the feature, than the icon itself. Why would we want this?

I was a little unclear in my PR, apologies.

I think this could be helpful for users who may have tinkered with settings and want to revert back to the out-of-the-box / default combination of settings that we recommend, especially as our feature-set continues to evolve.

(But if we really want this, I'd say actual text aligned to the right saying "Reset to defaults currentUndoIconHere")

How about this 😎 - update pushed to branch

Screenshot 2024-07-03 at 6 08 25 PM

@afonsojramos
Copy link
Member

@setchy took the liberty to push to this branch the option I think is the most viable. Hope that's okay.

Let me know what you think!
image

@setchy
Copy link
Member Author

setchy commented Jul 5, 2024

Works for me

@afonsojramos
Copy link
Member

I think it is a bit more clear right out of the gate and it's only visible if you're looking for it. Which, for a "deep" setting, makes sense!

@afonsojramos afonsojramos merged commit 8c7c3a1 into main Jul 5, 2024
8 checks passed
@afonsojramos afonsojramos deleted the feature/reset-default-settings branch July 5, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants