Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: add tests for direnv, configure bashrc.d #1054

Merged
merged 3 commits into from
May 16, 2023

Conversation

emattiza
Copy link
Contributor

@emattiza emattiza commented Mar 9, 2023

Description

due to related bugs #1049, this adds post build tests to the nix chunk for asserting PROMPT_COMMAND being set and _direnv_hook being available. Additionally, changes were made to source from a numbered startup bashrc in ~/.bashrc.d IPO appending to ~/.bashrc

Related Issue(s)

Fixes #1049

How to test

Standard Image Testing Applies

Release Notes

updated tool-nix chunk to emit direnv bashrc to $HOME/.bashrc.d/999-direnv instead of appending to $HOME/.bashrc

Documentation

@emattiza emattiza requested a review from a team March 9, 2023 04:30
@gitpod-io
Copy link

gitpod-io bot commented Mar 9, 2023

Copy link
Member

@axonasif axonasif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @emattiza! 🙌
Left a few (non-blocking) suggestions for consideration 🙏

tests/tool-nix.yaml Outdated Show resolved Hide resolved
chunks/tool-nix/Dockerfile Outdated Show resolved Hide resolved
@emattiza emattiza force-pushed the bug/direnv-postinstall-tests branch from 5453778 to f4cf73e Compare March 9, 2023 16:51
@emattiza emattiza requested a review from axonasif March 9, 2023 16:52
tests/tool-nix.yaml Outdated Show resolved Hide resolved
due to related bugs gitpod-io#1049, this adds post
build tests to the nix chunk for asserting PROMPT_COMMAND being set and
_direnv_hook being available. Additionally, changes were made to source
from a numbered startup bashrc in ~/.bashrc.d ipo appending to ~/.bashrc
@emattiza emattiza force-pushed the bug/direnv-postinstall-tests branch from f4cf73e to 22606d2 Compare March 9, 2023 18:13
@emattiza emattiza requested a review from axonasif March 9, 2023 18:24
@iQQBot iQQBot requested a review from a team May 15, 2023 14:27
@kylos101 kylos101 removed the request for review from a team May 15, 2023 20:53
Copy link
Contributor

@iQQBot iQQBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribute!

@iQQBot iQQBot merged commit 2425257 into gitpod-io:main May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Awaiting Deployment
Development

Successfully merging this pull request may close these issues.

DirEnv not loading variables from .envrc into the shell environment
3 participants