-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: add tests for direnv, configure bashrc.d #1054
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axonasif
approved these changes
Mar 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution @emattiza! 🙌
Left a few (non-blocking) suggestions for consideration 🙏
emattiza
force-pushed
the
bug/direnv-postinstall-tests
branch
from
March 9, 2023 16:51
5453778
to
f4cf73e
Compare
axonasif
reviewed
Mar 9, 2023
axonasif
approved these changes
Mar 9, 2023
due to related bugs gitpod-io#1049, this adds post build tests to the nix chunk for asserting PROMPT_COMMAND being set and _direnv_hook being available. Additionally, changes were made to source from a numbered startup bashrc in ~/.bashrc.d ipo appending to ~/.bashrc
emattiza
force-pushed
the
bug/direnv-postinstall-tests
branch
from
March 9, 2023 18:13
f4cf73e
to
22606d2
Compare
axonasif
approved these changes
Mar 13, 2023
iQQBot
approved these changes
May 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribute!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
due to related bugs #1049, this adds post build tests to the nix chunk for asserting PROMPT_COMMAND being set and _direnv_hook being available. Additionally, changes were made to source from a numbered startup bashrc in ~/.bashrc.d IPO appending to ~/.bashrc
Related Issue(s)
Fixes #1049
How to test
Standard Image Testing Applies
Release Notes
Documentation