Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load dynamic libraries on darwin #3669

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Load dynamic libraries on darwin #3669

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions pkg/proc/gdbserial/gdbserver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -922,6 +922,16 @@ continueLoop:
}
}

if p.BinInfo().GOOS == "darwin" {
images, err := p.conn.getLoadedDynamicLibraries()
if err != nil {
return nil, stopReason, fmt.Errorf("could not load dynamic libraries %s", err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to just log this: logflags.GdbWireLogger().Errorf(...)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 lines above there is a return statement for ElfUpdateSharedObjects. I believe behaviour for linux and darwin should be the same.

}
for _, image := range images {
p.bi.AddImage(image.Pathname, image.LoadAddress)
}
}

if err := p.setCurrentBreakpoints(); err != nil {
return nil, stopReason, err
}
Expand Down