Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #1189, commit messages containing a pipe #1218

Merged
merged 2 commits into from
Mar 16, 2017
Merged

fix #1189, commit messages containing a pipe #1218

merged 2 commits into from
Mar 16, 2017

Conversation

philfry
Copy link
Contributor

@philfry philfry commented Mar 11, 2017

this patch makes graphItemFromString split only the first 8 elements, leaving commit messages with pipes in it untouched.
(backport for release/v1.1)

@strk
Copy link
Member

strk commented Mar 11, 2017

Could you rewrite the commit log to include the identifier of the commit being backported ?

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 11, 2017
@lunny lunny added this to the 1.1.1 milestone Mar 11, 2017
@lunny lunny added the type/bug label Mar 11, 2017
@lunny
Copy link
Member

lunny commented Mar 11, 2017

backport from #1203

@lunny
Copy link
Member

lunny commented Mar 16, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 16, 2017
@appleboy
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 16, 2017
@lunny
Copy link
Member

lunny commented Mar 16, 2017

@philfry maybe you can rebase this.

@lunny
Copy link
Member

lunny commented Mar 16, 2017

let L-G-T-M work

@lunny lunny merged commit 2b5e4b4 into go-gitea:release/v1.1 Mar 16, 2017
ethantkoenig pushed a commit to ethantkoenig/gitea that referenced this pull request Apr 29, 2017
@philfry
fix go-gitea#1189, commit messages containing a pipe (go-gitea#1218)
f6b8238 
(d680164)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.1.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@philfry @strk @lunny @appleboy @tboerger