log: enhance README #272
Merged
log: enhance README #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [#76](https://github.com/go-kit/kit/pull/76), | ||
| [#131](https://github.com/go-kit/kit/issues/131), | ||
| [#157](https://github.com/go-kit/kit/pull/157), and | ||
| [#252](https://github.com/go-kit/kit/pull/252) |
There was a problem hiding this comment.
Please add #164 to this list. It explains why Logger.Log returns an error, and that seems to be a FAQ as well.
|
One request for an addition in-line, but otherwise LGTM. Thanks for doing this. At some point I'd like to sit down and craft some really nice godoc package comments. This will be a good reference point. |
guycook
pushed a commit
to codelingo/kit
that referenced
this pull request
Oct 12, 2016
log: enhance README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the log/README, as mentioned in issue 269. I'd love to include more links in the Benchmarks & comparisons section, but my search-fu is weak today.