Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the stack library dependency #10

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Remove the stack library dependency #10

merged 1 commit into from
Sep 16, 2021

Conversation

sagikazarmark
Copy link
Contributor

No description provided.

peterbourgon
peterbourgon approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@peterbourgon peterbourgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, brilliant. I'd thought the go-stack dep was more tightly integrated!

@sagikazarmark sagikazarmark merged commit 1befbfc into main Sep 16, 2021
@sagikazarmark sagikazarmark deleted the stack branch September 16, 2021 13:27
@ChrisHines
Copy link
Member

Ah, brilliant. I'd thought the go-stack dep was more tightly integrated!

It used to be, but I reduced its use in go-kit/kit#755. At the time I thought I'd removed it completely, but failed to notice it was also used in the tests.

@peterbourgon
Copy link
Member

OK, so any blockers to tagging current main as v0.2.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbourgon peterbourgon peterbourgon approved these changes

@ChrisHines ChrisHines Awaiting requested review from ChrisHines

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sagikazarmark @ChrisHines @peterbourgon