Versioned v3 according to Go wiki, maintaining backward compatibility #247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #246
Moved v3 to subdirectory to allow for versioning >2 with go modules.
Reverted top level go.mod to fix backward compatibility.
With Go Modules (
GO111MODULE=on
):go get github.com/go-ldap/ldap/v3
go get -u github.com/go-ldap/ldap/v3
go get github.com/go-ldap/ldap/[email protected]
.Without Go Modules, v3.0.3 will work (
GO111MODULE=off
, or go version <1.13):go get github.com/go-ldap/ldap
This complies with one of the suggested versioning methods from: https://github.com/golang/go/wiki/Modules#releasing-modules-v2-or-higher
Ideally we would increase the versioning number (rename v3 directory to v4, and the go.mod to v4) however this would stray from the LDAPv3 coupling.
https://tools.ietf.org/html/rfc4511
EDIT: Formatting