Logger Interface #245
Closed
Logger Interface #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 24, 2014 23:05
|
We might hold off on this. I want to land it, but only after codegangsta/inject#18 lands. This will make it so we can map the logger as is but still have it fulfill the interface with regards to dependency resolution |
|
@codegangsta Ok, no prob. |
|
is there any progress on this one? |
|
Lately I have been feeling alright with the extensibility Closing this issue for now |
Closed
|
@codegangsta totally disagree with you, log levels don't always goto separate files, and it provides no common interface across the entire application to do correct logging. I've not seen any logging package in any other language not have levels |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #174