Notwritten route pass to NotFound handler

[sevkin]

m.Get("/:page", func(p martini.Params, r render.Render) {
    if p["page"] == "im-exists" {
        r.HTML(200, "page", "all ok")
    }
    // else (another matched but not exists) - do nothing, pass me to NotFound
}

it`s a version 2 of #229

[sevkin]

@sgp I`m think is not a problem. application may explicit return 204

func main() {
    m := martini.Classic()
    m.Get("/", func(rw http.ResponseWriter) {
        // do something without content
        rw.WriteHeader(204)
    })
    m.Run()
}

as expected 204 without content

$ curl -i http://localhost:3000/
HTTP/1.1 204 No Content
Date: Fri, 25 Apr 2014 16:26:45 GMT
Content-Length: 0
Content-Type: text/plain; charset=utf-8

[sgp]

This is true; although this needs to be documented as a necessary change to existing code. We had many cases in our code where we used the default behavior (i.e. nothing written == 200 OK).

[codegangsta]

I just reverted this change. I'm happy to have this in as long as we document it's usage and notify current martini users of breaking changes on the mailing list before we land it.

[sgp]

I think that this kind of change would be better suited by having an explicit method call or return value that can grant this sort of behavior. Returning 200 OK by default (i.e. assuming handled, not "not found") is better default behavior IMHO.

[codegangsta]

Thanks for the input Scott!

On Fri, Apr 25, 2014 at 11:55 AM, Scott Parkerson
[email protected]:

I think that this kind of change would be better suited by having an
explicit method call or return value that can grant this sort of behavior.
Returning 200 OK by default (i.e. assuming handled, not "not found") is
better default behavior IMHO.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/246#issuecomment-41427415
.

[sgp]

No problem. We've been enjoying Martini here. :)