Feature/gcc warning errors #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compiling with gcc 8.4.0 with -Werror, the following error is
thrown:
src/logger.c:72:40: error: self-comparison always evaluates to true [-Werror=tautological-compare]
while (*p != '\0' && *q != '\0' && *p == *p) {
^~
cc1: some warnings being treated as errors
It is assumed that *p needs to be compared with *q
sidcha
reviewed
Nov 6, 2023
src/logger.c
Outdated
Comment on lines
6
to
8
| #ifndef _GNU_SOURCE | ||
| #define _GNU_SOURCE /* See feature_test_macros(7) */ | ||
| #endif |
There was a problem hiding this comment.
From a quick look, we are not using anything from _GNU_SOURCE. Without this, macro both libosdp and c-utils builds fine for me. Can you please check and remove _GNU_SOURCE here and in libosdp?
| @@ -69,7 +70,7 @@ static const char *get_rel_path(logger_t *ctx, const char *abs_path) | |||
|
|
|||
| p = ctx->root_path; | |||
| q = abs_path; | |||
| while (*p != '\0' && *q != '\0' && *p == *p) { | |||
| while (*p != '\0' && *q != '\0' && *p == *q) { | |||
Using gcc 8.4.0 throws this warning: libosdp/utils/include/utils/utils.h:31: warning: "BIT" redefined #define BIT(n) (1ull << (n)) It's safe to conditionally define this
Using gcc 8.4.0 throws this warning: libosdp/utils/src/logger.c:7: warning: "_GNU_SOURCE" redefined #define _GNU_SOURCE /* See feature_test_macros(7) */ However there is no need to use _GNU_SOURCE, it's safe to remove it.
badevos
force-pushed
the
feature/gcc-warning-errors
branch
from
7a6b573
to
9d13d1b
Compare
|
I have reordered my commits and changed the one on _GNU_SOURCE. As my environment sets _GNU_SOURCE, it's okay for me to remove it. |
sidcha
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm trying to integrate libosdp into another project, which is using gcc 8.4.0 with '-Werror'.
This has caused a few issues which can easily be resolved I guess.
In case you accept these changes, I can update the PR for libosdp, ignoring the submodule pointing to my fork.
Let me know your thoughts.
Thanks in advance.
Kr,
Bart.