This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Refactor to simplify #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the need to perform type switches by extending a parsed item's interface to know how to handle itself. This means we can better leverage the type system and remove the possibility that we can put anything into the channel that can't take an appropriate action on the connection. Have the Database manage creating connections, and don't pass the WaitGroup away from the main Database loop. The connection can terminate itself in response to a Disconnect now, simplifying some of the termination logic.
It's quite subtle that an Execute log isn't sufficient to resolve how to run the associated query. This commit removes the Handle method from Execute to clearly enforce that Execute should not be considered a complete parsed Item, forcing any code that wants to supply an Execute with the parameters it should be bound with.
This is a bit of a crap-shoot. I don't want to introduce locks around accessing the map because this may slow things down, but I definitely want to have the pending method and that requires reading the map while risking a concurrent write. I think we're highly unlikely to see any problems but want to call it out that Pending should be suspect if we begin to see segfaults.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.