-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all: require go 1.21+ for tools installation #3411
Milestone
Comments
Change https://go.dev/cl/588757 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
May 29, 2024
Gopls v0.15.x requires go 1.19 or newer. Update the README and the installation error message to clarify the extension requires go 1.19+. Gopls v0.16+ will require go 1.21+. The next staticcheck will require go 1.22+. If go1.21 is used, `go install` will be able to pick up go 1.22, so effectively, the extension does not have to worry about tool's go version requirement any more if the go version used for tools installation is go 1.21+. Encode these version mapping metrix in goTools.ts and installtools script. Run go run tools/generate.go -tools that updates gopls latest version. Fixes #3409 For #3411 Change-Id: Ib8177cda8c79a7251cb11f26ea3def18630f3858 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/588757 Commit-Queue: Hyang-Ah Hana Kim <[email protected]> Reviewed-by: Suzy Mueller <[email protected]> kokoro-CI: kokoro <[email protected]>
Putting this in the v0.42.0 milestone. @hyangah please remilestone if that is incorrect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The upcoming gopls requires go1.21+ for installation.
golang/go#65917
Update the min version in the README and tools installation logic.
The text was updated successfully, but these errors were encountered: