Upgrade spring framework to 3.2.2 #1108
Merged
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1108 +/- ##
=========================================
Coverage 52.02% 52.02%
Complexity 655 655
=========================================
Files 89 89
Lines 5388 5388
Branches 708 708
=========================================
Hits 2803 2803
Misses 2323 2323
Partials 262 262 ☔ View full report in Codecov by Sentry. |
chandrashekar-s
force-pushed
the
spring-upgrade
branch
from
94b4d70
to
bfe4e4b
Compare
bashir2
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
Thanks @chandrashekar-s; just some minor comments/question.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
This is to fix the upgrade issue caused by this PR.
The upgrade was failing because the latest Spring code as per this documentation needs to know the parameter names (embedded in the compiled classes) and does not deduce the names by parsing the bytecode. The compiler arg
-parametersis enabled by default forspring-boot-starter-parent.E2E test
Relied on automated e2e tests.
TESTED:
NA
Checklist: I completed these to help reviewers :)
I have read and will follow the review process.
I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review Java and Python style guides.
My IDE is configured to follow the Google code styles.
No? Unsure? -> configure your IDE.
I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
I ran
mvn clean packageright before creating this pull request and added all formatting changes to my commit.All new and existing tests passed.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master