Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds fhir-data-pipes helm chart #664

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

bennsimon
Copy link

Description of what I changed

  • Adds the helm chart for pipelines deployment.
    • Includes a sidecar support for deployment of spark-thriftserver alongside pipelines.
  • Adds the github workflow to publish helm chart on github as releases.
    • For this to work gh-pages (github pages branch) should be created on this repository.
  • Adds the documentation on how to use the helm chart.

E2E test

TESTED:

Tested by deploying pipelines, spark-thriftserver using this helm chart and openldap and spark cluster using open-source charts on a Kubernetes cluster. The services authenticate and communicate as expected.

Spark docker image used: docker.io/bitnami/spark:3.3.2-debian-11-r12

Checklist: I completed these to help reviewers :)

  • I have read and will follow the review process.

  • I am familiar with Google Style Guides for the language I have coded in.

    No? Please take some time and review Java and Python style guides.

  • My IDE is configured to follow the Google code styles.

    No? Unsure? -> configure your IDE.

  • I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)

  • I ran mvn clean package right before creating this pull request and added all formatting changes to my commit.

  • All new and existing tests passed.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@google-cla
Copy link

google-cla bot commented Apr 24, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@bennsimon bennsimon force-pushed the add-fhir-data-pipelines-chart branch from 037d149 to 10bf491 Compare April 24, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant