New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add __array_namespace_info__ and corresponding utilities #20294

Merged

copybara-service merged 1 commit into google:main from Micky774:array_namespace_info

Apr 11, 2024

Collaborator

Micky774 commented Mar 18, 2024

Towards #20200

This PR adds:

__array_namespace_info__
capabilities
default_device
default_dtypes
devices
dtypes
Tests for each of the above

Micky774 mentioned this pull request

Update jax.experimental.array_api to v2023.12 API #20200

Open

13 tasks

Micky774 force-pushed the array_namespace_info branch from 9e72911 to 2858f56 Compare

March 18, 2024 15:07

yashk2810 reviewed

View reviewed changes

jax/experimental/array_api/_utility_functions.py Show resolved Hide resolved

Micky774 force-pushed the array_namespace_info branch 3 times, most recently from b0eb8b9 to f429f8a Compare

March 18, 2024 15:40

jakevdp self-assigned this

jakevdp reviewed

View reviewed changes

jax/experimental/array_api/_utility_functions.py Show resolved Hide resolved

yashk2810 reviewed

View reviewed changes

jax/experimental/array_api/_utility_functions.py Outdated Show resolved Hide resolved

Micky774 force-pushed the array_namespace_info branch 2 times, most recently from 062a667 to 5dd83a5 Compare

March 18, 2024 17:20

jakevdp reviewed

View reviewed changes

jax/_src/numpy/inspection.py Outdated Show resolved Hide resolved

Micky774 force-pushed the array_namespace_info branch from 5dd83a5 to 7f4f7ef Compare

March 18, 2024 17:57

jakevdp reviewed

View reviewed changes

tests/array_api_test.py Outdated Show resolved Hide resolved

jax/experimental/array_api/_utility_functions.py Outdated Show resolved Hide resolved

Micky774 force-pushed the array_namespace_info branch from 7f4f7ef to 272c754 Compare

March 18, 2024 18:30

jakevdp reviewed

View reviewed changes

jax/experimental/array_api/_utility_functions.py Show resolved Hide resolved

jax/experimental/array_api/_utility_functions.py Outdated Show resolved Hide resolved

jakevdp reviewed

View reviewed changes

jax/experimental/array_api/_utility_functions.py Outdated Show resolved Hide resolved

Micky774 force-pushed the array_namespace_info branch 2 times, most recently from 6c34257 to 8497bae Compare

March 28, 2024 22:24

jakevdp approved these changes

View reviewed changes

jax/experimental/array_api/_utility_functions.py Outdated Show resolved Hide resolved

google-ml-butler bot added kokoro:force-run pull ready labels

kokoro-team removed the kokoro:force-run label

Micky774 force-pushed the array_namespace_info branch from 8497bae to 49e7274 Compare

April 4, 2024 22:40

jakevdp approved these changes

View reviewed changes

google-ml-butler bot added the kokoro:force-run label

kokoro-team removed the kokoro:force-run label

Collaborator

jakevdp commented Apr 5, 2024

There are some failures – it looks like the array_api_test needs to add a BUILD dependency on //jax:internal_test_util here:

jax/tests/BUILD

Lines 51 to 58 in f37e503

    
           py_test( 
        
               name = "array_api_test", 
        
               srcs = ["array_api_test.py"], 
        
               deps = [ 
        
                   "//jax", 
        
                   "//jax:experimental_array_api", 
        
               ] + py_deps("absl/testing"), 
        
           )

Micky774 force-pushed the array_namespace_info branch from 49e7274 to da5e9b7 Compare

April 9, 2024 22:17

jakevdp reviewed

View reviewed changes

tests/BUILD Outdated Show resolved Hide resolved


          Add __array_namespace_info__ and corresponding utilities

e6508a4

Micky774 force-pushed the array_namespace_info branch from da5e9b7 to e6508a4 Compare

April 11, 2024 14:21

jakevdp approved these changes

View reviewed changes

google-ml-butler bot added the kokoro:force-run label

kokoro-team removed the kokoro:force-run label

copybara-service bot merged commit 301c351 into google:main

14 checks passed

Micky774 deleted the array_namespace_info branch

April 11, 2024 19:23

Micky774 mentioned this pull request

Remaining API changes for array API compliance #21088

Closed

9 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment