Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jnp.tile for array API 2023 #20943

Closed
wants to merge 1 commit into from

Conversation

Micky774
Copy link
Collaborator

Towards #20200

  • Begins deprecation of jax.numpy.tile signature.
  • Adds new jax.experimental.array_api.tile as a thin wrapper over jax.numpy.tile.
  • Improves DeprecatedArg class by allowing for a customizable repr message.

@jakevdp
Copy link
Collaborator

jakevdp commented Apr 25, 2024

I don't think this change is necessary: the array API specifies that the arguments to tile are passed by position. jnp.tile accept arguments passed by position, thus we support specification-compatible calls to the function without any changes to the code. Yes, we also support arguments passed by keyword, but that doesn't conflict with the specification.

Deprecations are painful for users, and we should avoid them unless they are absolutely necessary. As long as JAX provides a superset of the specification API, we should not make changes.

What do you think?

@Micky774
Copy link
Collaborator Author

Micky774 commented Apr 25, 2024

That makes sense, and indeed this would be a painful deprecation to follow through...I'll go ahead and close this and separate the array_api namespace uodate👍

@Micky774 Micky774 closed this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants