Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename rcond/tol to rtol in linalg.matrix_rank and linalg.pinv #21226

Merged
merged 1 commit into from
May 14, 2024
Merged

Rename rcond/tol to rtol in linalg.matrix_rank and linalg.pinv #21226

merged 1 commit into from
May 14, 2024

Conversation

Micky774
Copy link
Collaborator

Towards #21088

This PR:

  • Deprecates the tol argument of linalg.matrix_rank in favor of rtol
  • Deprecates the rcond argument of linalg.pinv in favor of rtol

cc: @jakevdp

@Micky774 Micky774 force-pushed the linalg-depr branch 2 times, most recently from 76379cb to 9c06888 Compare May 14, 2024 19:22
@Micky774 Micky774 mentioned this pull request May 14, 2024
Closed
9 tasks
jakevdp
jakevdp reviewed May 14, 2024
View reviewed changes
Copy link
Collaborator

@jakevdp jakevdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

jax/_src/scipy/special.py Outdated Show resolved Hide resolved
@jakevdp jakevdp self-assigned this May 14, 2024
jakevdp
jakevdp approved these changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@jakevdp jakevdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@google-ml-butler google-ml-butler bot added kokoro:force-run pull ready Ready for copybara import and testing labels May 14, 2024
@copybara-service copybara-service bot merged commit 1dff5b3 into google:main May 14, 2024
14 checks passed
@Micky774 Micky774 deleted the linalg-depr branch May 18, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakevdp jakevdp jakevdp approved these changes

Assignees

@jakevdp jakevdp

Labels
pull ready Ready for copybara import and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Micky774 @jakevdp @kokoro-team