Remove 'from __future__ import annotations' #22125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakevdp
approved these changes
Jun 26, 2024
google-ml-butler
bot
added
kokoro:force-run
pull ready
|
Hmm. Apparently this change isn't a no-op. I guess definition ordering matters? |
|
Lint failures are because ruff is linting in Python 3.9: Line 104 in 2985b62 |
|
Oh, but maybe the future annotations import is still needed to get the behavior of https://peps.python.org/pep-0649/ |
|
ruff fix in #22126 |
|
Yeah, we still need that import in some cases and tbh it's probably a good idea to have it by default to avoid paying the runtime cost of type annotations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.