[pallas] Improve some error messages and add API tests. #22173
Merged
+338
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnecula
force-pushed
the
pallas_errors
branch
9 times, most recently
from
e821c8b
to
0d09d05
Compare
gnecula
force-pushed
the
pallas_errors
branch
10 times, most recently
from
5417817
to
c5c67b6
Compare
sharadmv
approved these changes
Jul 3, 2024
justinjfu
approved these changes
Jul 3, 2024
gnecula
force-pushed
the
pallas_errors
branch
2 times, most recently
from
7936254
to
3dcbc6f
Compare
We make the following improvements:
* pytree structural disequality messages now attempt to localize the
mismatch using tree_util.KeyPath.
* we generate a simpler error message for when `in_specs` is not
a sequence, instead of the current PyTreeDef mismatch error.
* we generate an error message for when the index map function
in a BlockSpec returns an unexpected number of results.
* added error localization to the existing shape polymorphism
check that the block shapes are static.
* We check that the kernel function returns None. Without this
we used to get `body_fun output and input must have same type structure`
in the interpreter, `assert len(jaxpr.outvars) == 0` on GPU,
and `INTERNAL: Mosaic failed to compile TPU kernel: has 1 operands, but enclosing function (@main) returns 0`
on TPU.
* we check that the rank of the block_shape matches the rank of
the overall array. Without this we used to get a `safe_zip`
error. We also carry the pytree paths to localize the error.
To simplify the generation of the error messages we added a helper
function `tree_util.equality_errors_pytreedef`, which is just like
`tree_util.equality_errors` but takes `PyTreeDef` inputs rather than
PyTrees. We then used this new helper function in `pjit.py` and `stages.py`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We make the following improvements:
mismatch using
tree_util.KeyPath.in_specsis nota sequence, instead of the current PyTreeDef mismatch error.
returns an unexpected number of values.
check that the block shapes are static.
the overall array. Without this we used to get a
safe_ziperror. We also carry the pytree paths to localize the error.
we used to get
body_fun output and input must have same type structurein the interpreter,
assert len(jaxpr.outvars) == 0on GPU,and
INTERNAL: Mosaic failed to compile TPU kernel: has 1 operands, but enclosing function (@main) returns 0on TPU.
To simplify the generation of the error messages we added a helper
function
tree_util.equality_errors_pytreedef, which is just liketree_util.equality_errorsbut takesPyTreeDefinputs rather thanPyTrees. We then used this new helper function in
pjit.pyandstages.py.