Prefer __qualname__ as a pjit_p name #22237
Merged
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If applying `jit` to a class method, it is often important to know the class name in the jaxpr.
superbobry
reviewed
Jul 2, 2024
superbobry
approved these changes
Jul 2, 2024
|
Have you considered instead expanding |
Yes, see my response to Sergei. Doing that broke tests and I'd rather make the minimal change that solves the problem I have (jaxpr readability). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If applying
jitto a class method, it is often important to know the class name in the jaxpr.