Clean up old GFileCache implementation
#22253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayaka14732
force-pushed
the
lru-cache-5
branch
4 times, most recently
from
6dddbd5
to
3f823c0
Compare
|
Manually tested on GPU VM and it works. |
ayaka14732
force-pushed
the
lru-cache-5
branch
2 times, most recently
from
904e197
to
080cda0
Compare
3 tasks
ayaka14732
force-pushed
the
lru-cache-5
branch
3 times, most recently
from
2eaaf46
to
7960933
Compare
superbobry
approved these changes
Jul 3, 2024
| @@ -19,8 +19,10 @@ | |||
|
|
|||
| try: | |||
| import etils.epath as epath | |||
| epath_installed = True | |||
There was a problem hiding this comment.
I guess you could use epath is not None instead of epath_installed?
There was a problem hiding this comment.
I think having a epath_installed is clearer, because it is imported in another file and is used multiple times.
google-ml-butler
bot
added
kokoro:force-run
pull ready
ayaka14732
force-pushed
the
lru-cache-5
branch
5 times, most recently
from
28c1e41
to
c291eab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up of #21926. It is part of the efforts to add LRU cache eviction policy for the JAX persistent compilation cache.
Since we now have the new
LRUChacheclass, which supports both local filesystem and GCS, the oldGFileCacheclass can be removed.