Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce lock's range in DeleteObsoleteFiles #386

Merged
merged 3 commits into from
May 30, 2019
Merged

Conversation

ivanabc
Copy link
Contributor

@ivanabc ivanabc commented Jun 20, 2016

lock spend too much time in DeleteObsoleteFiles

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@ivanabc
Copy link
Contributor Author

ivanabc commented Jun 20, 2016

I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@googlebot
Copy link

CLAs look good, thanks!

@cmumford
Copy link
Contributor

@googlebot rescan

@cmumford
Copy link
Contributor

@ivanabc can you please rebase this PR on master to make it more current? No problem with your CL, just an issue with our sync tool's ability to deal with old branches.

@cmumford cmumford merged commit 63d5315 into google:master May 30, 2019
cmumford added a commit that referenced this pull request May 30, 2019
PiperOrigin-RevId: 250702492
Copy link

@npatod npatod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some question regarding this pull request.
1)use case of mutex_.AssertHeld() (called at the beginning of function DBImpl::DeleteObsoleteFiles() )
I think It might be used to allow only one thread to delete a file.
2)if we do not want any synchronisation in this function then no need to call unlock at the beginning of function and again calling lock at the end of function.ideally if we don't required any synchronisation then no need to acquire lock for this function call (before we calling this function)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants