-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reduce lock's range in DeleteObsoleteFiles #386
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
CLAs look good, thanks! |
@googlebot rescan |
@ivanabc can you please rebase this PR on master to make it more current? No problem with your CL, just an issue with our sync tool's ability to deal with old branches. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some question regarding this pull request.
1)use case of mutex_.AssertHeld() (called at the beginning of function DBImpl::DeleteObsoleteFiles() )
I think It might be used to allow only one thread to delete a file.
2)if we do not want any synchronisation in this function then no need to call unlock at the beginning of function and again calling lock at the end of function.ideally if we don't required any synchronisation then no need to acquire lock for this function call (before we calling this function)
lock spend too much time in DeleteObsoleteFiles