Merge pull request #870 from ryandesign/ryandesign-protobuf-lite

Fix overlinking with protobuf
google · May 24, 2023 · cb22883 · cb22883
2 parents f2219b5 + 4183597
commit cb22883
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -75,7 +75,7 @@ endif()
 if (SPM_USE_BUILTIN_PROTOBUF)
   set(libprotobuf_lite "")
 else()
-  set(libprotobuf_lite "-lprotobuf-lite")
+  set(libprotobuf_lite "protobuf-lite")
 endif()
 
 if (MSVC)

diff --git a/sentencepiece.pc.in b/sentencepiece.pc.in
@@ -6,5 +6,6 @@ includedir=@includedir_for_pc_file@
 Name: @PROJECT_NAME@
 Description: Unsupervised text tokenizer and detokenizer for Neural Network-based text generation.
 Version: @PROJECT_VERSION@
-Libs: -L${libdir} -lsentencepiece -lsentencepiece_train @libprotobuf_lite@ @pkgconfiglibs@
-Cflags: -I${includedir} @pkgconfigcflags@
+Libs: -L${libdir} -lsentencepiece -lsentencepiece_train
+Cflags: -I${includedir}
+Requires.private: @libprotobuf_lite@