syntax: add benchmarks for scanning and parsing #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ie1269b8899c4454dc955c7453ed9e9266aceaaa3
jayconrod
reviewed
Aug 21, 2019
| @@ -47,6 +47,23 @@ func Parse(filename string, src interface{}, mode Mode) (f *File, err error) { | |||
| return f, nil | |||
| } | |||
|
|
|||
| // ScanAndDiscard tokenizes the input data and discards the tokens. | |||
| // Parameters are as for Parse. | |||
| // It exists only for internal benchmarking purposes. | |||
There was a problem hiding this comment.
It's unfortunate this needs to be part of the external API for benchmarking. Could the "scan" benchmark be moved to the syntax package instead?
xsadegh
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.