Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time: per-thread time.now() function #517

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

ash2k
Copy link
Contributor

@ash2k ash2k commented Oct 29, 2023

Closes #516.

p.s. there are quite a few changes that go fmt wants to make. I kept them out of this PR.

@ash2k ash2k force-pushed the per-thread-time branch 2 times, most recently from 55bf278 to 92e53c1 Compare October 29, 2023 03:46
Copy link
Collaborator

@adonovan adonovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Code looks good.

lib/time/time.go Outdated Show resolved Hide resolved
lib/time/time.go Outdated Show resolved Hide resolved
lib/time/time.go Outdated Show resolved Hide resolved
lib/time/time.go Outdated Show resolved Hide resolved
lib/time/time.go Outdated Show resolved Hide resolved
lib/time/time.go Outdated Show resolved Hide resolved
@adonovan
Copy link
Collaborator

p.s. there are quite a few changes that go fmt wants to make. I kept them out of this PR.

Thanks. I've posted #519.

Copy link
Collaborator

@adonovan adonovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tests!

lib/time/time.go Outdated Show resolved Hide resolved
lib/time/time_test.go Show resolved Hide resolved
@adonovan adonovan merged commit 556fd59 into google:master Nov 1, 2023
13 checks passed
@ash2k ash2k deleted the per-thread-time branch November 1, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

time: allow to inject per-module or per-thread now()
2 participants