Skip to content

Commit

Permalink
pkg/rpcserver: don't fail requests in LocalRun
Browse files Browse the repository at this point in the history
It's assumed that the caller would use a context to control waits on
individual requests.
  • Loading branch information
a-nogikh authored and dvyukov committed Jul 8, 2024
1 parent 2a09015 commit b1dad17
Showing 1 changed file with 0 additions and 19 deletions.
19 changes: 0 additions & 19 deletions pkg/rpcserver/local.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,9 @@ package rpcserver

import (
"context"
"errors"
"fmt"
"os"
"os/exec"
"time"

"github.com/google/syzkaller/pkg/cover"
"github.com/google/syzkaller/pkg/flatrpc"
Expand Down Expand Up @@ -100,23 +98,6 @@ func RunLocal(cfg *LocalConfig) error {
cmd.Process.Kill()
<-res
}
if !cfg.HandleInterrupts {
// If the executor has crashed early, reply to all remaining requests to unblock tests.
loop:
for {
req := serv.execSource.Next()
if req == nil {
select {
case <-cfg.Context.Done():
break loop
default:
time.Sleep(time.Millisecond)
continue loop
}
}
req.Done(&queue.Result{Status: queue.ExecFailure, Err: errors.New("executor crashed")})
}
}
return cmdErr
}

Expand Down

0 comments on commit b1dad17

Please sign in to comment.