Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syz-manager: refactor empty crash log errors #5063

Merged
merged 1 commit into from
Jul 17, 2024
Merged

syz-manager: refactor empty crash log errors #5063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions pkg/repro/repro.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,6 @@ type execInterface interface {
*instance.RunResult, error)
}

var ErrNoPrograms = errors.New("crash log does not contain any programs")

func Run(crashLog []byte, cfg *mgrconfig.Config, features flatrpc.Feature, reporter *report.Reporter,
pool *dispatcher.Pool[*vm.Instance]) (*Result, *Stats, error) {
exec := &poolWrapper{
Expand All @@ -87,7 +85,7 @@ func prepareCtx(crashLog []byte, cfg *mgrconfig.Config, features flatrpc.Feature
exec execInterface) (*reproContext, error) {
entries := cfg.Target.ParseLog(crashLog)
if len(entries) == 0 {
return nil, ErrNoPrograms
return nil, fmt.Errorf("crash log (%d bytes) does not contain any programs", len(crashLog))
}
crashStart := len(crashLog)
crashTitle, crashType := "", crash.UnknownType
Expand Down
4 changes: 0 additions & 4 deletions syz-manager/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,10 +458,6 @@ func reportReproError(err error) {
}

switch err {
case repro.ErrNoPrograms:
// This is not extraordinary as programs are collected via SSH.
log.Logf(0, "repro failed: %v", err)
return
case repro.ErrNoVMs:
// This error is to be expected if we're shutting down.
if shutdown {
Expand Down
Loading