Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API calls in turbinia-client commands #1398

Merged
merged 5 commits into from
Nov 20, 2023

Conversation

jleaniz
Copy link
Collaborator

@jleaniz jleaniz commented Nov 17, 2023

Description of the change

This PR update the methods used in API requests to use the ones that support the preload_content argument. It also adds a new response decoding method to handle cases where the API client does not deserialize the responses automatically, as is the case when preload_content in the requests is set to False.

Applicable issues

  • fixes #

Additional information

Checklist

  • All tests were successful.
  • Unit tests added.
  • Documentation updated.

@jleaniz jleaniz requested a review from aarontp November 20, 2023 16:42
@jleaniz jleaniz self-assigned this Nov 20, 2023
@aarontp
Copy link
Member

aarontp commented Nov 20, 2023

LGTM

@jleaniz jleaniz merged commit 7b5a8c8 into google:master Nov 20, 2023
5 checks passed
jleaniz added a commit to jleaniz/turbinia that referenced this pull request Feb 28, 2024
* Update API calls

* Update turbiniacli class

* Updates to turbiniacli

* Updates to commands

* Updates to decode_api_response
jleaniz added a commit to jleaniz/turbinia that referenced this pull request Mar 18, 2024
* Update API calls

* Update turbiniacli class

* Updates to turbiniacli

* Updates to commands

* Updates to decode_api_response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants