-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the "Using Docker for Job execution" documentation #1415
Updated the "Using Docker for Job execution" documentation #1415
Conversation
The documentation article "Using Docker for Job execution" was updated so it reflects the code in line 124 `turbinia/turbinia/lib /docker_manager.py`.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Thanks for the PR @HelferDCSO ! Could you please check the info on the CLA above and sign that if you haven't already?: #1415 (comment) @hacktobeer and/or @wajihyassine These changes LGTM, but could you double check since I wasn't sure why we had the image ID instead of the image name. Thanks all! |
Thanks Aaron, let me take a look at this tomorrow. |
@HelferDCSO Small feedback. Where do you see/find that the configuration filename has been changed to |
@hacktobeer Your absolutely right, the file is called In my PR I misspelled turbinia, which will be fixed in the next commit. I also misspelled it in my PR description. Sorry for the unpleasantries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comments, looks good, thanks for updating these docs!
@HelferDCSO Thank you veyr much for this PR, looks good to me and I am going to merge. |
* Updated the "Using Docker for Job execution" documentation The documentation article "Using Docker for Job execution" was updated so it reflects the code in `turbinia/turbinia/lib/docker_manager.py`.
* Updated the "Using Docker for Job execution" documentation The documentation article "Using Docker for Job execution" was updated so it reflects the code in `turbinia/turbinia/lib/docker_manager.py`.
The documentation article "Using Docker for Job execution" was updated so it reflects the code in line 124
turbinia/turbinia/lib /docker_manager.py
.Description of the change
The changes update the documentation article Using Docker for Job execution so that it reflects the code in docker_manager.py#L111.
The following errors occur when using the
IMAGE ID
instead of theREPOSITORY
value:Since the function
image_exists(self, image_id)
docker_manager.py#L111 doesn't use the image id but rather the image name, the documentation needed to be updated.Changed the "Using Docker for Job execution" article in the documentation. The documentation know explains that the image name is required. Also the name of the configuration file was changed to
turbinia.conf
.Applicable issues
Additional information
Checklist