-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workaround for pinfo non-json warning output #1418
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
We need to cherry pick this on top of the last release! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know
@@ -1070,6 +1070,8 @@ def _validate(self): | |||
log.info(f'Running pinfo.py to validate PlasoFile {self.local_path}') | |||
command = subprocess.run(cmd, capture_output=True, check=True) | |||
storage_counters_json = command.stdout.decode('utf-8').strip() | |||
# pinfo.py might print warnings (non-json) so we only need to last line of output | |||
storage_counters_json = storage_counters_json.splitlines()[-1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
turbinia/evidence.py
* add workaround for pinfo warning output (#1418) * Update version to 20231116.1 * Fix plaso dependencies (#1420) * fix deps * fix test * Update version to 20231116.2 * Fix plaso dependencies (#1420) * fix deps * fix test * update docs link --------- Co-authored-by: hacktobeer <[email protected]> Co-authored-by: Aaron Peterson <[email protected]>
* add workaround for pinfo warning output (google#1418) * Update version to 20231116.1 * Fix plaso dependencies (google#1420) * fix deps * fix test * Update version to 20231116.2 * Fix plaso dependencies (google#1420) * fix deps * fix test * update docs link --------- Co-authored-by: hacktobeer <[email protected]> Co-authored-by: Aaron Peterson <[email protected]>
* add workaround for pinfo warning output (google#1418) * Update version to 20231116.1 * Fix plaso dependencies (google#1420) * fix deps * fix test * Update version to 20231116.2 * Fix plaso dependencies (google#1420) * fix deps * fix test * update docs link --------- Co-authored-by: hacktobeer <[email protected]> Co-authored-by: Aaron Peterson <[email protected]>
Description of the change
Make sure we only use the relevant json output of pinfo.py
Applicable issues
Additional information
Checklist