-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base #1439
Merged
Merged
Base #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the PR @sa3eed3ed. LGTM, please remove any modifications to files under the |
go back to access_token to not break OpenAPI configs automation
jleaniz
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jleaniz
pushed a commit
to jleaniz/turbinia
that referenced
this pull request
Feb 28, 2024
* Update turbiniacli.py * Update auth_helper.py * Update configuration.py * Update turbiniacli.py * Update configuration.py go back to access_token to not break OpenAPI configs automation * Update turbiniacli.py
jleaniz
pushed a commit
to jleaniz/turbinia
that referenced
this pull request
Mar 18, 2024
* Update turbiniacli.py * Update auth_helper.py * Update configuration.py * Update turbiniacli.py * Update configuration.py go back to access_token to not break OpenAPI configs automation * Update turbiniacli.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Allow passing ID token to the CLI and change access_token attribute in API client to ID token as ID token is more accurate here. Some free type annotation.