Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base #1439

Merged
merged 6 commits into from
Feb 20, 2024
Merged

Base #1439

merged 6 commits into from
Feb 20, 2024

Conversation

sa3eed3ed
Copy link
Contributor

Description of the change

Allow passing ID token to the CLI and change access_token attribute in API client to ID token as ID token is more accurate here. Some free type annotation.

@jleaniz
Copy link
Collaborator

jleaniz commented Feb 19, 2024

Thanks for the PR @sa3eed3ed. LGTM, please remove any modifications to files under the turbinia_api_client (e.g. configuraiton.py) package as this is autogenerated code.

go back to access_token to not break OpenAPI configs automation
Copy link
Collaborator

@jleaniz jleaniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jleaniz jleaniz merged commit e27631b into google:master Feb 20, 2024
5 checks passed
jleaniz pushed a commit to jleaniz/turbinia that referenced this pull request Feb 28, 2024
* Update turbiniacli.py

* Update auth_helper.py

* Update configuration.py

* Update turbiniacli.py

* Update configuration.py

go back to access_token to not break OpenAPI configs automation

* Update turbiniacli.py
jleaniz pushed a commit to jleaniz/turbinia that referenced this pull request Mar 18, 2024
* Update turbiniacli.py

* Update auth_helper.py

* Update configuration.py

* Update turbiniacli.py

* Update configuration.py

go back to access_token to not break OpenAPI configs automation

* Update turbiniacli.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants