Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Vue 3 Web Build with FastAPI #1453

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Fix Vue 3 Web Build with FastAPI #1453

merged 2 commits into from
Mar 11, 2024

Conversation

wajihyassine
Copy link
Member

@wajihyassine wajihyassine commented Mar 11, 2024

Description of the change

Fixes Web UI not properly loading with FastAPI due to directory structure changes as well as some other small nits

Applicable issues

  • fixes #

Additional information

Checklist

  • All tests were successful.
  • Unit tests added.
  • Documentation updated.

@wajihyassine wajihyassine self-assigned this Mar 11, 2024
Copy link
Collaborator

@jleaniz jleaniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

return FileResponse(file)

raise HTTPException(status_code=404, detail='Not found')
raise HTTPException(status_code=404, detail='Not found')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline

@wajihyassine wajihyassine merged commit fc37c0b into master Mar 11, 2024
13 checks passed
jleaniz pushed a commit to jleaniz/turbinia that referenced this pull request Mar 18, 2024
* Fix Vue 3 Web Build with FastAPI

* yapf fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants