Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to API client/server #1460

Merged
merged 20 commits into from
Apr 2, 2024
Merged

Updates to API client/server #1460

merged 20 commits into from
Apr 2, 2024

Conversation

jleaniz
Copy link
Collaborator

@jleaniz jleaniz commented Mar 26, 2024 •
edited
Loading

Description of the change

This PR introduces the following changes:

  • Code cleanup and minor dependencies updates to API client/server.
  • Use Turbinia logger for uvicorn error and access logs.
  • Implemented a new GET /api/result/plasofile{task_id} API endpoint to directly download a Plaso file associated with a specific Task ID.
  • Add new GET /api/config/version endpoint.
  • Updates turbinia-client and turbinia-api-lib with new endpoints.
  • Updates logging format to include module names in log lines.
  • Add a snackbar indicator to the web UI for request/task output downloads

Applicable issues

Additional information

All code changes in the turbinia/api/client/ directory are autogenerated and can be ignored during reviews.

Checklist

  • All tests were successful.
  • Unit tests added.
  • Documentation updated.

@jleaniz jleaniz changed the title Debug api downloads Updates to API client/server Mar 26, 2024
@jleaniz jleaniz self-assigned this Mar 26, 2024
@jleaniz jleaniz mentioned this pull request Mar 26, 2024
Closed
@jleaniz jleaniz requested a review from hacktobeer March 26, 2024 16:31
@jleaniz jleaniz marked this pull request as ready for review March 26, 2024 16:31
@jleaniz jleaniz removed the request for review from hacktobeer March 28, 2024 18:20
@jleaniz
Copy link
Collaborator Author

jleaniz commented Mar 28, 2024

@wajihyassine please review the changes to the Web UI code

@jleaniz
Copy link
Collaborator Author

jleaniz commented Mar 28, 2024

@aarontp please take a look when you can

wajihyassine
wajihyassine approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@wajihyassine wajihyassine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from Web UI side, thanks for making these changes!

aarontp
aarontp approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@aarontp aarontp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple small questions/nits. FYI, I didn't review the .vue files since wyassine has already reviewed those.

turbinia/api/cli/turbinia_client/core/commands.py Show resolved Hide resolved
turbinia/api/utils.py Outdated Show resolved Hide resolved
turbinia/task_manager.py Outdated Show resolved Hide resolved
@jleaniz jleaniz merged commit 479e220 into google:master Apr 2, 2024
5 checks passed
This was referenced May 30, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarontp aarontp aarontp approved these changes

@wajihyassine wajihyassine wajihyassine approved these changes

Assignees

@jleaniz jleaniz

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jleaniz @aarontp @wajihyassine