Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update debugging docs #1473

Merged
merged 9 commits into from
Apr 24, 2024
Merged

Update debugging docs #1473

merged 9 commits into from
Apr 24, 2024

Conversation

aarontp
Copy link
Member

@aarontp aarontp commented Apr 17, 2024

Description of the change

Update documentation on debugging

Applicable issues

Additional information

Checklist

  • All tests were successful.
  • Unit tests added.
  • Documentation updated.

Copy link
Member

@wajihyassine wajihyassine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just added a few small comments.

Thanks for updating this!

docs/user/debugging.md Show resolved Hide resolved
docs/user/debugging.md Outdated Show resolved Hide resolved
docs/user/debugging.md Outdated Show resolved Hide resolved
docs/user/debugging.md Outdated Show resolved Hide resolved
docs/user/debugging.md Show resolved Hide resolved
@aarontp
Copy link
Member Author

aarontp commented Apr 24, 2024

@wajihyassine thanks for the review, PTAL.

Copy link
Member

@wajihyassine wajihyassine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will wait for the tests to pass before merging

@aarontp aarontp merged commit a0dc6b9 into google:master Apr 24, 2024
5 checks passed
@aarontp aarontp deleted the update-docs branch April 24, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants