Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update e2e testing scripts #1501

Merged
merged 11 commits into from
Jun 20, 2024
Merged

Update e2e testing scripts #1501

merged 11 commits into from
Jun 20, 2024

Conversation

jleaniz
Copy link
Collaborator

@jleaniz jleaniz commented Jun 18, 2024

Description of the change

Updates to e2e test scripts.

Applicable issues

  • fixes #

Additional information

Checklist

  • All tests were successful.
  • Unit tests added.
  • Documentation updated.

@jleaniz jleaniz changed the title Fix e2e tests Update e2e testing scripts Jun 18, 2024
@jleaniz jleaniz self-assigned this Jun 18, 2024
@jleaniz jleaniz marked this pull request as ready for review June 19, 2024 22:41
Copy link
Member

@wajihyassine wajihyassine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing, overall LGTM minus one nit about the incrementing

turbinia/e2e/run-e2e-gke.sh Outdated Show resolved Hide resolved
turbinia/e2e/run-e2e-gke.sh Outdated Show resolved Hide resolved
Copy link
Member

@wajihyassine wajihyassine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wajihyassine wajihyassine merged commit 5d06b8b into google:master Jun 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants