Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turbinia Analyser Codelab #1512

Merged
merged 14 commits into from
Jul 31, 2024
Merged

Turbinia Analyser Codelab #1512

merged 14 commits into from
Jul 31, 2024

Conversation

hacktobeer
Copy link
Collaborator

Description of the change

This PR adds a Codelab on how to create a Turbinia analyser using the development environment based on vscode, minikube and skaffold. It demonstrates how debugging works with hot-reloading and file syncing enabled.

Applicable issues

None

Additional information

Checklist

  • All tests were successful.
  • Unit tests added.
  • Documentation updated.

@hacktobeer hacktobeer marked this pull request as draft July 24, 2024 13:43
@hacktobeer hacktobeer changed the title Turbinia Analyser Codelab [WIP] Turbinia Analyser Codelab Jul 28, 2024
@hacktobeer hacktobeer changed the title [WIP] Turbinia Analyser Codelab Turbinia Analyser Codelab Jul 29, 2024
@hacktobeer hacktobeer marked this pull request as ready for review July 29, 2024 13:54
Copy link
Member

@wajihyassine wajihyassine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -> straightforward read. I like how you approached this with a debug session example via failed path, shows the debug workflow / hot reloading workflow in action!

Copy link
Collaborator

@jleaniz jleaniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - The only thing I would add, if you feel up to it, is how to write a test for the new analyzer or add a reference that new analyzers should come with tests and point to an example?

@jleaniz jleaniz merged commit afb1277 into google:master Jul 31, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants