-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turbinia Analyser Codelab #1512
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -> straightforward read. I like how you approached this with a debug session example via failed path, shows the debug workflow / hot reloading workflow in action!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - The only thing I would add, if you feel up to it, is how to write a test for the new analyzer or add a reference that new analyzers should come with tests and point to an example?
Description of the change
This PR adds a Codelab on how to create a Turbinia analyser using the development environment based on vscode, minikube and skaffold. It demonstrates how debugging works with hot-reloading and file syncing enabled.
Applicable issues
None
Additional information
Checklist