Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API server config.download functionality. #1515

Merged
merged 9 commits into from
Jul 27, 2024

Conversation

hacktobeer
Copy link
Collaborator

@hacktobeer hacktobeer commented Jul 25, 2024

Description of the change

This PR adds a config.download API end point to download the Turbinia configuration file in it's original format.

Applicable issues

Additional information

Checklist

  • All tests were successful.
  • Unit tests added.
  • Documentation updated.

@hacktobeer hacktobeer requested a review from jleaniz July 25, 2024 08:05
@hacktobeer
Copy link
Collaborator Author

@jleaniz first API server contribution. Can you have a look and see what needs to be added/changed?
Probably:

  • unit tests
  • do I need to generate the client? if so, how?

Copy link
Collaborator

@jleaniz jleaniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Here's some comments for you to review.

turbinia/api/routes/config.py Outdated Show resolved Hide resolved
@hacktobeer hacktobeer force-pushed the api-server-add-download-config branch from 236ee39 to 8bc9b98 Compare July 26, 2024 11:12
@hacktobeer
Copy link
Collaborator Author

@jleaniz PTAL -> tests added and rewritten to use FileResponse fastapi function.

@hacktobeer hacktobeer requested a review from jleaniz July 26, 2024 11:14
Copy link
Collaborator

@jleaniz jleaniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor comment. Congrats on your first API server PR :)

turbinia/api/routes/config.py Outdated Show resolved Hide resolved
@hacktobeer hacktobeer merged commit 9ff5440 into google:master Jul 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR]: API server - provide endpoint "config download" to download original configuration
2 participants