Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turbinia codelab 101 updates #1523

Merged
merged 13 commits into from
Aug 2, 2024
Merged

Turbinia codelab 101 updates #1523

merged 13 commits into from
Aug 2, 2024

Conversation

hacktobeer
Copy link
Collaborator

@hacktobeer hacktobeer commented Aug 2, 2024 •
edited
Loading

Description of the change

  • Several small textual updates to the codelab to clarify things better.
  • Raise the skaffold deadline from 30 to 90 seconds to give redis time to stabilize
  • Add httpx module to client dependencies as a replacement for the complete turbinia-client-library (ApiResponse issue)

Applicable issues

None

Checklist

  • All tests were successful.
  • Unit tests added.
  • Documentation updated.

@hacktobeer hacktobeer requested a review from jleaniz August 2, 2024 10:16
jleaniz
jleaniz approved these changes Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@jleaniz jleaniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jleaniz jleaniz merged commit bd51a8f into google:master Aug 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleaniz jleaniz jleaniz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hacktobeer @jleaniz