Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new API endpoints (logs, evidence) #1527

Merged
merged 13 commits into from
Aug 9, 2024
Merged

Conversation

jleaniz
Copy link
Collaborator

@jleaniz jleaniz commented Aug 8, 2024

Description of the change

This PR creates new API endpoints to retrieve log data for Turbinia components in a similar way to the "tail" command.

It also adds a new endpoint to download evidence files based on evidence IDs.

Applicable issues

Additional information

Checklist

  • All tests were successful.
  • Unit tests added.
  • Documentation updated.

@jleaniz jleaniz changed the title Added logs api endpoints Added new API endpoints (logs, evidence) Aug 8, 2024
@jleaniz
Copy link
Collaborator Author

jleaniz commented Aug 8, 2024

image

Copy link
Collaborator

@hacktobeer hacktobeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, love the log file endpoint with tailing.

turbinia/api/routes/logs.py Outdated Show resolved Hide resolved
turbinia/api/utils.py Show resolved Hide resolved
turbinia/api/utils.py Outdated Show resolved Hide resolved
@jleaniz jleaniz marked this pull request as ready for review August 8, 2024 19:31
@jleaniz jleaniz self-assigned this Aug 8, 2024
Copy link
Collaborator

@hacktobeer hacktobeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge after addresses small nit comments.

turbinia/api/openapi.yaml Outdated Show resolved Hide resolved
turbinia/api/routes/download.py Outdated Show resolved Hide resolved
turbinia/api/routes/evidence.py Outdated Show resolved Hide resolved
@jleaniz jleaniz requested a review from hacktobeer August 9, 2024 15:47
@jleaniz jleaniz merged commit a26ac60 into google:master Aug 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR]: API endpoint to retrieve logs
2 participants