Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebUI dev documentation and skaffold fix. #1529

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

hacktobeer
Copy link
Collaborator

@hacktobeer hacktobeer commented Aug 8, 2024

Description of the change

As the WebUI is build in Vue and we put a minified build in the API server it is not possible to debug this in the containers. This PR:

  • adds a paragraph to the dev documentation on how to develop for the WebUI
  • changes the skaffold config to prevent rebuilds of the api-server container when developing on the WebUI
  • fixes the web README as npm run serve does not work as there is no serve profile.

Applicable issues

  • fixes #

Additional information

Checklist

  • All tests were successful.
  • Unit tests added.
  • Documentation updated.

Copy link
Member

@wajihyassine wajihyassine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wajihyassine wajihyassine merged commit ee99f35 into google:master Aug 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants