Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebUI: Evidence and Worker download buttons #1532

Merged
merged 5 commits into from
Aug 23, 2024
Merged

WebUI: Evidence and Worker download buttons #1532

merged 5 commits into from
Aug 23, 2024

Conversation

wajihyassine
Copy link
Member

@wajihyassine wajihyassine commented Aug 13, 2024

Description of the change

Adds button to download evidence and worker logs. worker logs default to top 500 most recent logs

@wajihyassine wajihyassine self-assigned this Aug 13, 2024
@wajihyassine wajihyassine changed the title Add button next to evidence name to download WebUI: Evidence and Worker download buttons Aug 23, 2024
@wajihyassine wajihyassine marked this pull request as ready for review August 23, 2024 20:23
Copy link
Collaborator

@jleaniz jleaniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -12,6 +12,7 @@
*/_build/
/_sources/
/.tox
charts/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to add this? we don't have a charts directory.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes for the skaffold dev setup to ignore that folder else shows alot of noise in your commits tab in VSCode

@jleaniz jleaniz merged commit 4831195 into master Aug 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants