Make ConvertError and variants public
#1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jswrenn
force-pushed
the
pub-error-variants
branch
from
a4ecd00
to
75199c6
Compare
This permits matching on the error variant, and ensures that the variants are rendered in rustdoc. Makes progress on #1139.
jswrenn
force-pushed
the
pub-error-variants
branch
from
75199c6
to
8c1565d
Compare
joshlf
approved these changes
May 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1284 +/- ##
=======================================
Coverage 87.76% 87.76%
=======================================
Files 14 14
Lines 5158 5158
=======================================
Hits 4527 4527
Misses 631 631 ☔ View full report in Codecov by Sentry. |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This permits matching on the error variant, and ensures that the variants are rendered in rustdoc.
Makes progress on #1139.