Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added conditional dependancy downloading in CI #1471

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dorryspears
Copy link
Contributor

Progresses #1310

This will skip downloading the cargo dependencies if the cache is present. The cache gets refreshed based on the hash of the Cargo.toml file, so when that file doesn't change, this could save 2 - 3 minutes per run.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.34%. Comparing base (8151bdb) to head (15c00d5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1471   +/-   ##
=======================================
  Coverage   87.34%   87.34%           
=======================================
  Files          15       15           
  Lines        5303     5303           
=======================================
  Hits         4632     4632           
  Misses        671      671           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dorryspears
Copy link
Contributor Author

@joshlf If some of these commands need to be run regardless of the cache filling, I can split them up.

I have a feeling we still may want to run

  • cargo check --workspace --tests
  • cargo kani setup

cargo check --workspace --tests &> /dev/null &
cargo metadata &> /dev/null &
cargo install cargo-readme --version 3.2.0 &> /dev/null &
cargo install --locked kani-verifier &> /dev/null &
cargo install cargo-nextest &> /dev/null &
cargo kani setup &> /dev/null &

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants