Introduce invariant::Initialized and migrate Maybe to it
#853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This opens the door to implementing `TryFromBytes<Option<&T>>`, which is currently blocked on us needing to inspect whether the referent bytes are zeroed. We couldn't do that previously, since `AsInitialized` leaves the possibility for uninitialized bytes, which cannot be soundly checked for equality.
jswrenn
force-pushed
the
ptr-validity-initialized
branch
from
837a67e
to
a3d9780
Compare
joshlf
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This opens the door to implementing
TryFromBytes<Option<&T>>, which is currently blocked on us needing to inspect whether the referent bytes are zeroed. We couldn't do that previously, sinceAsInitializedleaves the possibility for uninitialized bytes, which cannot be soundly checked for equality; described here: rust-lang/unsafe-code-guidelines#488.