-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discovery samples: Ensure the last element of the Java import path is capitalized #151
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a comment
Joiner.on('.').join(packagePrefix, capitalize(apiTypeName))); | ||
} | ||
|
||
public static String capitalize(String str) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be public (maybe private is enough, I see it being used from getSErviceTypeName()?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Argh. Not fully fixed, it turns out. The references to the imported class are still lower-cased. I'll update this PR with a fix. |
Ok, that should be fixed now. I'll figure out how to add a test before I submit this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was causing problems for IAM, since the Discovery file said
"canonicalName" : "iam"
and thus the import in the sample readimport ....v1.iam;
instead ofimport ....v1.Iam;