Fix basic errors in integration/run_tests.py #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashir2
requested changes
Jan 16, 2018
setup.py
Outdated
| @@ -21,6 +21,8 @@ | |||
| # This is needed due to https://issues.apache.org/jira/browse/BEAM-3357. | |||
| 'grpcio>=1.3.5,<=1.7.3', | |||
| 'apache-beam[gcp]>=2.2', | |||
| 'google-api-python-client>=1.6', | |||
| 'google-cloud-bigquery>=0.25', | |||
There was a problem hiding this comment.
Are you sure that version 0.25 works or should this be > 0.25 (see my TODO above)?
There was a problem hiding this comment.
Nice catch. Done. It installed v0.29.0 on my machine.
| self.dataset = None | ||
|
|
||
| def __enter__(self): | ||
| client = bigquery.Client(project=self.project) | ||
| dataset_ref = client.dataset(self.dataset_id) | ||
| # TODO(bashir2): There is a mismatch between the bigquery API versions |
There was a problem hiding this comment.
I think you can remove this TODO now. BTW, I thought we need a version strictly greater than 0.25.
There was a problem hiding this comment.
Done. And good catch! I changed to be >0.25.
arostamianfar
force-pushed
the
inttest
branch
2 times, most recently
from
ce9566c
to
6c38e57
Compare
bashir2
previously approved these changes
Jan 16, 2018
setup.py
Outdated
| @@ -21,6 +21,11 @@ | |||
| # This is needed due to https://issues.apache.org/jira/browse/BEAM-3357. | |||
| 'grpcio>=1.3.5,<=1.7.3', | |||
| 'apache-beam[gcp]>=2.2', | |||
| # Note that adding 'google-api-python-client>=1.6' causes some dependency | |||
| # mismatch issues if using 'setup.py install'. See Issue #71. | |||
There was a problem hiding this comment.
nit: dependency issues are there no matter we use setup.py install or not, the difference seems to be that setup.py install stops while pip install continues but still installs conflicting versions.
arostamianfar
force-pushed
the
inttest
branch
2 times, most recently
from
d5b55d9
to
2ef275f
Compare
bashir2
previously approved these changes
Jan 16, 2018
arostamianfar
force-pushed
the
inttest
branch
from
2ef275f
to
8567a4c
Compare
bashir2
previously approved these changes
Jan 17, 2018
arostamianfar
force-pushed
the
inttest
branch
from
8567a4c
to
0ab727f
Compare
bashir2
approved these changes
Jan 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: The tests still do not run successfully e2e (table deletion fails when cleaning up), but they progress further :)
Issue #62