Merge pull request #1800 from xushiwei/q

TestTypeAndValue, TestConvErr
goplus · Mar 8, 2024 · f39646c · f39646c
2 parents 89f4bb0 + 3097f6a
commit f39646c
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/cl/internal/typesutil/api_test.go b/cl/internal/typesutil/api_test.go
@@ -35,6 +35,10 @@ func TestTypeAndValue(t *testing.T) {
 	if ret.Value == nil {
 		t.Fatal("NewTypeAndValueForValue: not const?")
 	}
+	ret = NewTypeAndValueForValue(ty, constant.MakeInt64(1), Constant)
+	if ret.Value == nil {
+		t.Fatal("NewTypeAndValueForValue: not const?")
+	}
 	ret = NewTypeAndValueForCallResult(tyInt, nil)
 	if !ret.IsValue() {
 		t.Fatal("NewTypeAndValueForCall: not value?")

diff --git a/x/typesutil/builtin_test.go b/x/typesutil/builtin_test.go
@@ -0,0 +1,18 @@
+package typesutil
+
+import (
+	"errors"
+	"testing"
+
+	"github.com/goplus/gogen"
+)
+
+func TestConvErr(t *testing.T) {
+	e := errors.New("foo")
+	if ret, ok := convErr(nil, &gogen.ImportError{Err: e}); !ok || ret.Msg != "foo" {
+		t.Fatal("convErr:", ret, ok)
+	}
+	if _, ok := convErr(nil, e); ok {
+		t.Fatal("convErr: ok?")
+	}
+}