Merge pull request #1494 from xushiwei/typesutil

typesutil.Check fix: exprLHS

cl/builtin_test.go

@@ -50,6 +50,24 @@ func TestErrMultiStarRecv(t *testing.T) {
 	})
 }
 
+func TestErrAssign(t *testing.T) {
+	defer func() {
+		if e := recover(); e == nil {
+			t.Fatal("TestErrAssign: no panic?")
+		}
+	}()
+	ctx := &blockCtx{}
+	compileAssignStmt(ctx, &ast.AssignStmt{
+		Tok: token.DEFINE,
+		Lhs: []ast.Expr{
+			&ast.SelectorExpr{
+				X:   ast.NewIdent("foo"),
+				Sel: ast.NewIdent("bar"),
+			},
+		},
+	})
+}
+
 func TestErrPanicToRecv(t *testing.T) {
 	ctx := &blockCtx{
 		tlookup: &typeParamLookup{

cl/expr.go

@@ -355,6 +355,10 @@ func compileSelectorExprLHS(ctx *blockCtx, v *ast.SelectorExpr) {
 		}
 	default:
 		compileExpr(ctx, v.X)
+		if rec := ctx.recorder(); rec != nil {
+			e := ctx.cb.Get(-1)
+			rec.Type(v.X, types.TypeAndValue{Type: e.Type, Value: e.CVal})
+		}
 	}
 	ctx.cb.MemberRef(v.Sel.Name, v)
 }

cl/stmt.go

@@ -210,6 +210,7 @@ func compileAssignStmt(ctx *blockCtx, expr *ast.AssignStmt) {
 			if v, ok := lhs.(*ast.Ident); ok {
 				names[i] = v.Name
 			} else {
+				compileExprLHS(ctx, lhs) // only for typesutil.Check
 				log.Panicln("TODO: non-name $v on left side of :=")
 			}
 		}